nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Comments on commits not visible in pull request

Sebastian Dietrich

Bitbucket has the possibility to show all commits for a specific PR and to comment specific lines in those commits.

Unfortunately these comments are not shown in the PR, just in the single commits.

I know that one can do iterative reviews using "changes since last review", but nevertheless sometimes people just comment commits during a pull request. And that is then typically forgotten since it is not visible.

Accepted answers

Patrik S

Hello @Sebastian Dietrich ,

and thank you for reaching out to Community!

It's important to note that pull requests evolve over time as new commits are pushed to them, so the portion of the file where a comment was added in the past, might have been deleted/modified in the newer commits.

However, in the pull request's Files changed tab, the unresolved comments on previous commits are still accessible in each respective file in the form of a button with the message "X other comments" as indicated by number 2 in the following example :

Screenshot 2024-07-18 at 6.19.55 PM.png

Clicking that button will open a pop-up window containing all the comments for that particular file in the current and previous commits, so you can review/resolve the comments individually

On the same page, button 1. will show the sum of all unresolved comments, including the latest and previous commits. By clicking on that button, you can select each individual comment, and the UI will open it accordingly.

I hope that information helps! Should you have any questions, let us know!

Thank you, @Sebastian Dietrich !

Patrik S

All comments

Patrik S

Hello @Sebastian Dietrich ,

and thank you for reaching out to Community!

Screenshot 2024-07-18 at 6.19.55 PM.png

Clicking that button will open a pop-up window containing all the comments for that particular file in the current and previous commits, so you can review/resolve the comments individually

I hope that information helps! Should you have any questions, let us know!

Thank you, @Sebastian Dietrich !

Patrik S

Sebastian Dietrich

Hi @Patrik S and thanks for your answer.

Sure new commits can change/delete the portion of the file, where a comment was added. Same is true for comments in the PR itself, where such comments are marked as outdated. I would wish that the behavior were the same, no matter if the comment was on the commit of a PR or on the PR itself.

Unfortunately your answer concerning the files changed tab is not correct: I just added a new test-comment to the latest commit of a PR:

comment added to last commit.jpg changes since last review.jpg The comments tab does not show it. Neither the number of unresolved comments changes, nor is it shown in the pop-up window (neither under unresolved nor resolved comments), nor is it visible in the respective file:

Patrik S

Hello @Sebastian Dietrich ,

thank you for sharing the screenshots.

The reason why you're getting a different behavior is that you're adding a comment on the Commits page rather than on the Pull Request page. Those are different types of comments and pull requests will indeed not show the comments that were made directly in the Commit section.

If you'd like to comment on a particular commit and review these comments as part of the pull request, you should select the commit directly from the pull requests page:

Screenshot 2024-07-22 at 4.58.57 PM.png

By clicking on that drop down all the commits within that pull request will be listed, so you can pick the one you want to add comments to, and they will be part of the pull request review and shown in the Unresolved count.

I hope that helps! Let me know in case you have any questions.

Thank you, @Sebastian Dietrich !

Patrik S

Sebastian Dietrich

Hi @Patrik S,

thanks for the explanation. I didn't know that I can reach the commits of a PR via the Files changed tab. I always clicked on the Commits tab of the PR which brought me to the list of commits in that PR (like the ones in the Files changed tab) but when clicking on one of them I obviously lose the focus of the PR and am directed to the overall Commits.

So the behavior "comment on a commit of a PR and show that comment in that PR" is already implemented. Then my request is the following: When clicking on the Commits tab of a PR (and then select one of the commits) one should get the exact same behavior as when clicking on the Files changed tab (and then select one of the commits).

Thanks,

Sebastian

Welcome!

It looks like you're new here. Sign in or register to get started.

Quick Links

Unanswered
Groups
Help

Find more posts tagged with

cloud

bitbucket-cloud