nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Adding user to pull request does not prioritize users with repo write access

andytomlin

When creating a pull request I cannot find users reliably. For example, in pics below Chris Brewer is a user with write access

However when I try to add him to a pull request he is not in the search results - including if you scroll it down. You cannot add by email address either

It seems like users with write access to the repo should be high priority search candidates. I have seen this problematic behavior in other user input selector dialog boxes.

Accepted answers

All comments

Theodora Boudale

Hi @andytomlin,

I triggered a sync in our permissions system for this user and for the repository. Could you please check if you are able to find this user now when adding reviewers to a PR of this repo?

Kind regards,
Theodora

andytomlin

Theodora,

We worked around the problem with Chris by having him navigate to the pull and make a comment. This then put him at the top of the list to be added to the pull.

However Ashwini Kumar is the same test case - he has permissions to the repo. Unfortunately I cant tell if he is the correct reviewer as there are a lot of Ashwini Kumar's. I have asked him to add a unique pic to his profile so when he does that I will retest.

Either way it sucks not to be able to add reviewers via email address in a public repo. The current dialog is pretty useless as you just have a long list of names and no way to discriminate or tell if its the right or the wrong user. Certainly with Ashwini its not obvious that the Ashwini with write privileges is the first one. Note that in both Chris and Ashwini's cases they had not made a commit to the repo.

andytomlin

Ok, Ashwini added a profile pic and I can confirm he does not show up in the add reviewer drop down. However I see his profile pic in the user and group access in repository settings.

It is definitely a bug

I would recommend any dialog box where your selecting a user you allow the use of email address.

Theodora Boudale

Hi @andytomlin,

I made the same sync for the user Ashwini that has access to your repo.

Could you please let me know if you are able to find this user now when adding PR reviewers?

Users with access to the repo should have a label 'MEMBER' next to their name in the user picker dropdown, as follows:

Screenshot 2022-09-02 at 12.39.16.png

If a user doesn't have this, it's not one of your users with explicit access.

I have created a request for prioritizing users with explicit access in that user picker for public repos (this issue occurs with public repos, for private repos only team members are displayed):

https://jira.atlassian.com/browse/BCLOUD-22118

Kind regards,
Theodora

Welcome!

It looks like you're new here. Sign in or register to get started.

Quick Links

Find more posts tagged with

cloud

bitbucket

bitbucket-cloud