EXTRA_ARGS: --filter bug

bobby jenrow_drpaod

There seems to be an issue with proper escaping of filters in the rsync EXTRA_ARGS variable.

• Version: atlassian/rsync-deploy:0.7.1
• log:

  
  
  <span>INFO: Starting RSYNC deployment to server:$THEME_DIR...</span>
  
  <span>rsync -rp --delete-after --filter='P assets/css' --exclude-from=project/rsync-excludes ./ user@server:$THEME_DIR</span>
  
  <span>Unknown filter rule: `'P'</span>
  
  <span>rsync error: syntax or usage error (code 1) at exclude.c(927) [client=3.1.3]</span>
  
  <span>&#10006; Deployment failed.</span><span>INFO: Executing the pipe...</span>

• steps to reproduce:
  • Try to run --filter inside the EXTRA_ARGS variable

Igor Stoyanov

@bobby jenrow hi. Thanks for your feedback.

Your error is due to whitespace in your filter command.
Try this in your pipe variables:

script:
  - pipe: atlassian/rsync-deploy:0.7.1
    variables:
    ...
    'EXTRA_ARGS_COUNT': 1,
    'EXTRA_ARGS_0': "--filter=P assets/css"

 

or if you have more then one extra arg in example 2 args:

script:
  - pipe: atlassian/rsync-deploy:0.7.1
    variables:
    ...
    'EXTRA_ARGS_COUNT': 2,
    'EXTRA_ARGS_0': "--filter=P assets/css",
    'EXTRA_ARGS_1': "--exclude=*2.txt"

 Double quotes is necessary.
We will update the README to provide this example as workaround for whitespaces.

Regards, Igor.