Is there a way to have a rework state that isn't a pull reject but isn't an accept yet?

Question

Pull request comments ask for a change that takes a bit.  Every reviewer sees the push notifications getting the suggestion addressed and none know if it is ready to re-review.  Email is sent to hold off until I am done, etc..

Is there a way to move a pull request to a rework state until ready?

David Goldman_qdfrdc · Answer

We have tasks assigned when there are expectations in a pull before merging. 
"Change requested" is not all inclusive.  There are questions or comments that require response even if it isn't a requested code change.

If the requested changes are addressed, it doesn't mean all the questions and comments have been responded to or that the overall changes are complete beyond the specific change requested.

If the reviewers put a task or change request on every comment then this would work.  They don't because that isn't obviously a requirement.

It would still benefit to have an explicit state for reworking.

Also, in our particular setup, there is no declined, only rejected and pulls cannot be reopened.  A new one is needed and the comment history is in the old pr.  Awkward.

Fabio Racobaldo · Answer

Hi @David Goldman ,

"Change Requested" status should help you on that.

Please, take a look to the following article https://bitbucket.org/blog/a-new-status-for-pull-requests-in-bitbucket-cloud-changes-requested

Hope this helps,

Fabio