Try out the new Bitbucket Cloud pull request experience today!

Viewing page 8 of 13

302 answers

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
July 1, 2019

Hi Manish,

Thanks for your comment. We've recently made some improvements in this area:

  1. You can expand or collapse all files via a button in the "..." menu on each file
  2. We've added lines changed counts to the file tree

We're continuing to focus on large PR reviewability, so stay tuned for more updates. We're planning to persist sidebar width across page loads, which should help.

Thanks,

Alastair

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
July 1, 2019

Thanks, we'll take a look.

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
July 1, 2019

Hi Roman,

Thanks for the feedback! We plan to replace "Likes" with emoji reactions in the future.

We're considering other workflow improvements in this area, but we need to work through some other items first.

Thanks,
Alastair

0 votes
Ed Lomonaco
Contributor
July 1, 2019

yup, it shows the deleted file, which I collapse when I see it

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
July 1, 2019

Hi Edward,

Deleted files should be collapsed by default. Are you seeing something different?

Thanks!
Alastair

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
July 1, 2019

Hi Joao,

For now, we're only rolling out to customers who don't use features we haven't added back yet. We plan to add task support soon.

If the new UI was enabled for your team, but your team regularly uses tasks, let us know your team's ID via a support ticket (https://support.atlassian.com/bitbucket-cloud) so we can take a closer look at why that happened.

Thanks!

Alastair

0 votes
Jon June 28, 2019

If a comment is added on a file that was changed and then the change itself is later reverted, there's no net change in the file, so it doesn't appear in the PR.  However, the comment itself still appears in the Activity card (appropriate, since it happened).  However, clicking the link for it causes the whole page to error.

In the old experience, the comment itself is displayed in the Activity tab, in code context (e.g. the code as it was when it was commented on) with the elipses to expand the context. 

This is very important so we know the full discussion around the change and the decision to revert.  For now, it's at least not lost (that is, if it errors I can switch off the new experience and see the comment). 

Can you make it so we can still see the comment and the code context at time of comment?

0 votes
Manish Maharjan June 28, 2019

@Alastair Wilkes , Is there any eta when those above requested features would be available? Additionally, it really seems like there should be some shortcuts or buttons for expanding and collapsing long list of Pull Requests easily. Whenever there are 100's of files are changed, it seems very difficult to browse through with new Pull Request experience. 

0 votes
Joao Squillace Teixeira June 28, 2019

Wondering why adding tasks are not a priority for this new pull request experience. It keeps pushing us to switch, but tasks are one essential part of my company's PR review. I tried to switch a bunch of times, but always end up coming back to the old version for this reason mainly

0 votes
Ed Lomonaco
Contributor
June 14, 2019

can the deleted files be collapsed by default? it'll make reviewing important things easier

0 votes
Jon June 7, 2019

Right now the Activity card fails to load for me on all PRs or I'd go look, but I'm wondering if the clicked comment is not just opened and scrolled to, but also highlighted.  That would be super useful if there are more comments in the popup than one.

0 votes
brahmana June 6, 2019

You are right. It is scrolling to the relevant comment. Whatever workflow I described is still possible with the new UI. I think I just need to update my mental model.

Only thing is it slows down a bit with the "Click -> Throbber -> Pop up appears -> Close" cycle where as the in the old UI it is just "Scroll up". But that's just a trade off I suppose.

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
June 5, 2019

Hi Srirang,

Thanks for your feedback.

The "Activity" window only has links, clicking on which the "Previous Comments" pop-up comes up show ALL the previous comments. In that pop-up I do not know which of the previous comments are actually from the last review session only.

After the pop-up opens, it should scroll you to the comment you clicked on. Is that not happening?

Further if the comment was on a line which got deleted in a subsequent commit, new UI can't show any code context for that.

We'll look into this. Thanks!

0 votes
Jon May 31, 2019

100 emoji

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
May 31, 2019

Hi Roman,

Thanks for trying out the new UI.

Yes, we plan to bring that back.

Thanks!

Alastair

0 votes
Roman Proshin May 27, 2019

Thanks for the great new UI! I really like it! But there is a feature that I miss: I can't see approvals from the pull request author. And it was possible in the old version. And this feature is quite important for our team because we use it as a sign that the pull request is ready for review: if the pull request is approved by the author then it's ready, otherwise the author is still working on/fixing it. Do you have any plans to introduce this feature back in the new UI?

0 votes
Jon May 13, 2019

Another user commented twice on a PR.  They later deleted one of the comments.  It now looks like this, even though the other comment remaining still shows their avatar and name:

formeruser.png

Should the deleted comment still show the avatar and name of the author?  They definitely aren't a former user.

The Activity cart on the right also still correctly shows their avatar and name.

0 votes
Jon May 8, 2019

One thing the old PR experience had that was very valuable was for "Comments on prior versions" there was the ... icon above and below the changes to fetch the next 10 adjacent lines so you could get the context.  

Often for outdated versions of the file that had comments attached the line numbers are quite different, so being able to expand to gain a bit more context is very helpful.  Otherwise we have to guess which commit the old comment was added on and try to find where in the code the comment was added by crawling through the history in git.

0 votes
Jon May 8, 2019

One major issue I'm facing is that the Delete link for comments is immedialy adjacent to the Edit link, and there's no confirmation dialog when you click Delete like on the old experience.   It's too easy to accidentally delete important comments when you really wanted to edit them!  Can you add a confirm on the delete?

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
May 6, 2019

The new UI is now back! Thanks for your patience.

0 votes
Maxim Leonov
Contributor
May 6, 2019

Unable to comment on an empty file diff.

Annotation 2019-05-07 095751.jpg

Intended or a bug?

It's convenient to be able to comment on such diffs especially if the're mistakenly committed.

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
May 6, 2019

Hi Sébastien,

The option to use the new UI will be back soon -- sorry for the inconvenience!

Alastair

0 votes
Alastair Wilkes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
May 6, 2019

Hi Srirang,

The option to use the new UI will be back soon -- sorry for the inconvenience!

Alastair

0 votes
sgautrin
Contributor
May 6, 2019

What's going on with the new pull-request experience? Suddenly I am back to the old experience, with the lab option no longer available (and that with both my work account and my personal account)...

0 votes
brahmana May 6, 2019

@Alastair Wilkes  The new UI is gone. The option to enable this in the bitbucket labs is also gone.

Does this mean you guys are going for a general public roll out or is something off??

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events