Amended commits trashes pull request's comments

I had a commit that I wanted changed and did a amend git and force pushed that up. But when I went back to the pull request, the comments that were on that are now gone. Is this intended?

1 answer

1 accepted

Hi Erik,

Did you just alter the commit message or the actual contents?

Updates to a file in a pull request can cause comments to disappear. We attempt to put the comments back on the correct line however this is not always possible for example when the line is removed from the file.

It is not possible for me to comment on whether this particular comment should have been drifted or not as I don't know the particulars.

The bitbucket team wrote a detailed description (see the "High Plains Drifter" section) of how they implemented comment drift which may help you understand how this issue is approached.

Lastly I am not clear is this a bitbucket pull request or a Stash pull request?

Regards,

Tom

Suggest an answer

Log in or Sign up to answer
Community showcase
Published Thursday in Summit

Find a your Summit 2019 Buddy!

Can you believe there's less than one month until Summit 2019? It's time to start planning your agendas, not to mention packing ... In the meantime, introduce yourselves on this thread so that you ...

287 views 16 7
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you