It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Amended commits trashes pull request's comments

I had a commit that I wanted changed and did a amend git and force pushed that up. But when I went back to the pull request, the comments that were on that are now gone. Is this intended?

1 answer

1 accepted

Hi Erik,

Did you just alter the commit message or the actual contents?

Updates to a file in a pull request can cause comments to disappear. We attempt to put the comments back on the correct line however this is not always possible for example when the line is removed from the file.

It is not possible for me to comment on whether this particular comment should have been drifted or not as I don't know the particulars.

The bitbucket team wrote a detailed description (see the "High Plains Drifter" section) of how they implemented comment drift which may help you understand how this issue is approached.

Lastly I am not clear is this a bitbucket pull request or a Stash pull request?

Regards,

Tom

Suggest an answer

Log in or Sign up to answer
Community showcase
Published in Off-topic

Atlassian Community Guide to A+ Articles

Stop: Articles and permission Article-writing permissions are given to Leaders, Marketplace Vendors, Solutions Partners, Atlassian Team members, and those who are Level 4 + above. But for any aspir...

55 views 5 4
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you