How will bitbucket handle both Minimum approvals and Minimum Successful Builds Merge Checks Enabled

Question

How will bitbucket handle both Minimum approvals and Minimum Successful Builds Merge Checks Enabled?

If an reviewer approves the pull request and a build hasn't run yet, will a merge not occur? Vice versa if a build succeeds and a reviewer hasn't approved the pull request, what happens?

Samuel Chow · Answer

In bamboo I enabled the merge push on master for Gatekeeper configuration. It seems to merge to master if build succeeds bypassing reviewers needed.

The plan branch builds on commit. I'm guessing that when a commit occurs, it starts the build and if the build succeeds before a user can create a pull request, the branch gets merged to master. Is that correct?

If this is the case I guess I have to rely on manual triggering of the plan branch after a review has been finished?

jredmond · Answer

If both are enabled then both are required.