Can Stash reject commits from unknown users?

Balázs Szakmáry

(We are using Stash 3.7.1)

We have a user called X Y Z (actually has three names, but this probably does not matter). Until now, his .gitconfig contained the correct name, but an incorrect e-mail address (x.z@company.com instead of xy.z@company.com) and was able to push commits to a repo which is not public and is configured (in the project) to accept commits only from a group (that he does belong to). The pushes succeeded because the username/password used for the HTTP authentication correctly mapped to the user.

I would like to avoid this kind of situation in the future. Is there a way to make Stash reject pushes containing commits which do not map to valid Stash users? (Or, preferably, Stash users with write permissions to the repo.)

JamieA

It's a case of examining the information for each commit, and attempting to look up the email address provided in the commit with a StashUser, then verifying that user has write permission to the repository.

Stash makes this relatively easy... if you example the author property of each commit, it will either be a Person (someone not in the system), or a StashUser (someone in the system).

It can be done with a pre-commit hook but I'm not sure it's worth it depending on what you are trying to achieve. If it's just accidental misconfiguration or someone inadvertently pushing someone's changes to a repo they don't have access to, then, yeah. But if it's for audit or security reasons, this can only work properly with signed commits imho, because anyone can change their git config.