Has anyone been able to get this to work?

Question

This question is in reference to Atlassian Documentation: How to disable attachment downloads

Ask your question here...

John Luu_qkpwt1 · Answer

I followed the steps to disable download of certain file types (basically copy and paste the code base and deleted the specified lines) but it didn't work. Am I missing anything? Below is taken from listattachmentsforspace.vm: $action.getActionName($action.getClass().getName()) #macro (sortHover $sortByLink) #if (!($sortBy == $sortByLink))sortHover#end #end #applyDecorator("root") #decoratorParam("helper" $action.helper) #decoratorParam("context" "space-operations") #decoratorParam("mode" "view-space-operations") #applyDecorator ("root") #decoratorParam ("context" "spacecontentpanel") #decoratorParam("helper" $action.helper) #decoratorParam("selection" "space-attachments") #decoratorParam("selectedSpaceToolsWebItem" "space-attachments") #requireResource("confluence.web.resources:attachments")

#set ($results = $action.paginationSupport.page) #if (!$results.empty || $textUtil.stringSet($fileExtension) || $labelsCount > 0) #end #if (!$results.empty) #pagination($action.paginationSupport "listattachmentsforspace.action?key=$!generalUtil.urlEncode($key)&startsWith=$!generalUtil.urlEncode($!action.startsWith)&sortBy=$!generalUtil.urlEncode($!sortBy)&fileExtension=$!generalUtil.urlEncode($!fileExtension)&") #foreach ($attachment in $results) #set ($labels = $attachment.labels) #set ($labelable = $attachment) #set($disabledDownloads = ['txt', 'html','png','css','jpg','js']) #set($disabled = false) #set($attachmentExtension = $attachment.fileExtension) #foreach($doNotDownload in $disabledDownloads) #if($attachmentExtension == $doNotDownload) #set($disabled = true) #break #end #end #if(!$disabled) #else #end #end

#sortLink("" "$req.contextPath/spaces/listattachmentsforspace.action?key=$!generalUtil.urlEncode($space.key)&fileExtension=$!generalUtil.urlEncode($!fileExtension)&sortBy=" $action.getText('columnheading.name'))	#sortLink("size" "$req.contextPath/spaces/listattachmentsforspace.action?key=$!generalUtil.urlEncode($space.key)&fileExtension=$!generalUtil.urlEncode($!fileExtension)&sortBy=size" $action.getText('columnheading.size'))	$action.getText('creator.name')	#sortLink("createddate" "$req.contextPath/spaces/listattachmentsforspace.action?key=$!generalUtil.urlEncode($space.key)&fileExtension=$!generalUtil.urlEncode($!fileExtension)&sortBy=createddate" $action.getText('columnheading.creation.date'))	#sortLink("date" "$req.contextPath/spaces/listattachmentsforspace.action?key=$!generalUtil.urlEncode($space.key)&fileExtension=$!generalUtil.urlEncode($!fileExtension)&sortBy=date" $action.getText('space-last-mod-date'))	$action.getText('labels.name')	$action.getText('attached.to')
#parse ("/pages/includes/attachment_icon.vm") $generalUtil.shortenString($attachment.fileName, 50)	#parse ("/pages/includes/attachment_icon.vm") $generalUtil.shortenString($attachment.fileName, 50)	$!attachment.niceFileSize	#userLink($!attachment.creator)	$dateFormatter.formatDateTime($!attachment.creationDate)	$dateFormatter.formatDateTime($!attachment.lastModificationDate)	#parse("/labels/labels-editor-content.vm")	#contentLink2 ($!attachment.getContent() true false)

#pagination($action.paginationSupport "listattachmentsforspace.action?key=$!generalUtil.urlEncode($key)&startsWith=$!generalUtil.urlEncode($!action.startsWith)&sortBy=$!generalUtil.urlEncode($!sortBy)&fileExtension=$!generalUtil.urlEncode($!fileExtension)&") #else #if ($textUtil.stringSet($fileExtension)) $action.getText('currently.no.attachments.in.space.ending.with.ext', ["$generalUtil.htmlEncode($fileExtension)"]) #if($labelsCount > 1) $action.getText('currently.no.attachments.also.with.labels', ["$generalUtil.htmlEncode($labels)"]) #elseif($labelsCount == 1) $action.getText('currently.no.attachments.also.with.label', ["$generalUtil.htmlEncode($labels)"]) #end #elseif($labelsCount > 1) $action.getText('currently.no.attachments.in.space.with.labels', ["$generalUtil.htmlEncode($labels)"]) #elseif($labelsCount == 1) $action.getText('currently.no.attachments.in.space.with.label', ["$generalUtil.htmlEncode($labels)"]) #else $action.getText('currently.no.attachments.in.space') #end #end

#end #end and from attachments-table.vm: ## Common template for building the attachments table ## When changing this file, check the attachment macro as well. ## Required Parameters: ## * $attachmentHelper - object used to obtain context and previous versions ## * $sortPathPrefixHtml - the url to goto when sorting ## * $showActions - 'true' if actions column is to be displayed ## * $old - 'true' if older versions are to be displayed #if ($old == "true") #end #if ($showActions == "true") #end ## Create a dummy Attachment ID, for when there aren't attachment IDs set (e.g. WebDAV) #set ($dummyAttachmentId = 1) #foreach( $attachment in $latestVersionsOfAttachments ) #set ($currentAttachmentId = $attachment.id) #set ($labels = $attachment.labels) #set ($labelable = $attachment) ## When the attachment ID isn't set (e.g. when we're using WebDAV), assign it an arbitrary number and increment #if ($currentAttachmentId.intValue() == 0) #set ($currentAttachmentId = $dummyAttachmentId) #set ($dummyAttachmentId = $dummyAttachmentId + 1) #end #set ($allVersions = $attachmentHelper.getAllVersions($attachment)) #if ($old == "true") #end #if ($showActions == "true") #end #if ($old == "true" && $allVersions.size() > 0) #foreach( $attachmentVersion in $allVersions ) #if ($showActions == "true") #end #end #end #end

	#sortLink("name", "${sortPathPrefixHtml}name" $action.getText('name.word'))	#sortLink("size", "${sortPathPrefixHtml}size" $action.getText('file.size'))	$action.getText('creator.name')	#sortLink("createddate" "${sortPathPrefixHtml}createddate" $action.getText('columnheading.creation.date'))	$action.getText('labels.name')	$action.getText('comment.name')
#if ($allVersions.size() > 0) #end	#parse ("/pages/includes/attachment_icon.vm") #set($disabledDownloads = ['txt', 'html', 'png', 'css', 'jpg', 'js']) #set($disabled = false) #set($attachmentExtension = $attachment.fileExtension) #foreach($doNotDownload in $disabledDownloads) #if($attachmentExtension == $doNotDownload) #set($disabled = true) #break #end #end #if(!$disabled) $generalUtil.htmlEncode($generalUtil.shortenString($attachment.fileName)) #else $generalUtil.htmlEncode($generalUtil.shortenString($attachment.fileName)) #end	$attachment.niceFileSize	#userLink($attachment.creator)	$action.dateFormatter.formatDateTime($attachment.creationDate)	#parse("/labels/labels-editor-content.vm")	#if ($attachment.comment && $attachment.comment.trim().length() > 0) $generalUtil.htmlEncode($attachment.comment) #else #end	#set ($webInterfaceContext = $attachmentHelper.getWebInterfaceContext($action.webInterfaceContext, $attachment)) #set($webItems = $action.webInterfaceManager.getDisplayableItems("system.attachment", $webInterfaceContext)) #if ($webItems.size() > 0) #foreach ($item in $webItems) #set ($isCurrent = ($context == $item.key)) #renderItemLink($item $isCurrent $webInterfaceContext) #end #else #end
	#if ($velocityCount == 1)$action.getText("attach.file.version.current", $attachmentVersion.getVersion())#else$action.getText("attach.file.version.dated", $attachmentVersion.getVersion())#end	#if(!$attachmentHelper.attachmentsInWebDavFolder)$attachmentVersion.niceFileSize#else #end	#if (!$attachmentHelper.attachmentsInWebDavFolder) #userLink($attachmentVersion.creator) #else #end	#if(!$attachmentHelper.attachmentsInWebDavFolder)$action.dateFormatter.formatDateTime($attachmentVersion.creationDate)#else #end		#if (!$attachmentHelper.attachmentsInWebDavFolder && $attachmentVersion.comment && $attachmentVersion.comment.trim().length() > 0) $generalUtil.htmlEncode($attachmentVersion.comment) #else #end	#set ($webInterfaceContext = $attachmentHelper.getWebInterfaceContext($action.webInterfaceContext, $attachmentVersion)) #set($webItems = $action.webInterfaceManager.getDisplayableItems("system.attachment.history", $webInterfaceContext)) #if ($webItems.size() > 0) #foreach ($item in $webItems) #set ($isCurrent = ($context == $item.key)) #renderItemLink($item $isCurrent $webInterfaceContext) #end #else #end

Thanks!

Nic Brough -Adaptavist- · Answer

Yes, but it is pointless, as they were attached for a good reason.