Jira Hooks for Stash returns error code when other - non related - ticket is in wrong state

Question

Using Stash 3.6.1 / JIRA 6.3.3.

I am having problems with a user pushing a commit to Stash (IP-721) but it fails with a error message that IP-719 (?!) is in the wrong state. This is correct as it is Closed. But how does it come with IP-719 (it is not a sub-task of 721) ?

Problem was resolved by disabling the plugin.

I do not use the Merge Check part, only the push check.

git.exe push --progress  "origin" IP-721-REPLACED:IP-721-REPLACED

Counting objects: 108, done.
Delta compression using up to 8 threads.
Compressing objects: 100% (34/34), done.
Writing objects: 100% (34/34), 3.87 KiB | 0 bytes/s, done.
Total 34 (delta 28), reused 0 (delta 0)

remote: The related issue IP-719 is not in the correct state (Actual state: Closed | Expected state: In_Resolution)To http://einappl32:7990/scm/ac/ipipe.git

! [remote rejected] IP-721-REPLACED -> IP-721-REPLACED (pre-receive hook declined)

error: failed to push some refs to 'http://einappl32:7990/scm/ac/ipipe.git'

git did not exit cleanly (exit code 1) (20468 ms @ 23-4-2015 16:29:48)

unknown · Answer

Hello,

I've installed the JIRA Hooks for Stash plugin in my stash instance and activated the Issue Checks in the "Push Check" Plugin. I've tested it with my keys and so far it worked.

Then I tried to check on "Issue status" and wrote in out "IN_PROGRESS" state from out workflow where we should push new commits. It didn't work! I disabled it again and removed the string but I get alway the same message when I want to push new commits:

Counting objects: 8, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (3/3), done.
Writing objects: 100% (3/3), 290 bytes | 0 bytes/s, done.
Total 3 (delta 2), reused 0 (delta 0)
remote: Hook com.lb.software.stash.jira.connector.checks.push.PushGuardCheck failed. Error: 
remote: java.lang.String cannot be cast to net.minidev.json.JSONObject
To http://user@ourstashserver:7990/scm/dmy/9999_dummy_repository.git
! [remote rejected] master -> master (pre-receive hook declined)
error: failed to push some refs to 'http://user@ourstashserver:7990/scm/dmy/9999_dummy_repository.git'

When I uncheck the Issue Check or deactivating the plugin I can push to my repo.

Is there any config file for this addon? Is it possible that the string is still somewhere?

How can I solve this? I already tried an reinstallation. Didn't help.

Anyway I honestly have to say I'm very confused about how to configure this AddOn.

Kind regards

Andi

Benjamin Mueller · Answer

Hey Mark,

in this version you are using, each commit which will pushed to the repository will be checked. Also older commits which has been pushed already in other branches. If you will merge already pushed branches in your local branch and push this branch again, then all commit will be checked again from the hook.

Now the good news. I have published today the new release 2.0, which will check commits only once. If they have been pushed in a previous session, then the checks will be skipped, if the commit will be pushed again.

Cheers Benjamin

steve_2t0f35 · Answer

Hi Mark, I'm glad you found a workaround for your problem. Any chance you are using a third party plugin? If you suspect it might be a JIRA/Stash problem, I'd recommend raising a support request ( https://confluence.atlassian.com/display/STASH/Raising+a+request+with+Atlassian+Support ) so that it can be looked into a little further.