Validation of "Select List" based on number fields.

Serj Shcherbakov

Hello, experts!

I faced with the problem of validation "select list field" via behavior plugin. 
If I filled number fields then update the validation doesn't work properly, if try to update it once again that validation is working.

Here is my Code:

def CoP = getFieldByName("Currency of payments to partners")
def NC = getFieldByName("NC mark-up to Billable costs (if applicable)")
def OPNB = getFieldByName("Other payments to partners (Non-Billable)")
def HPNB = getFieldByName("Hosting payments to partners (Non-Billable)")
def HWNB = getFieldByName("HW payments to partners (Non-Billable)")
def PSNB = getFieldByName("PS payments to partners (Non-Billable)")
def SMNB = getFieldByName("S&M payments to partners (Non-Billable)")
def LPNB = getFieldByName("License payments to partners (Non-Billable)")
def OPB = getFieldByName("Other payments to partners (Billable)")
def HPB = getFieldByName("Hosting payments to partners (Billable)")
def HWB = getFieldByName("HW payments to partners (Billable)")
def PSB = getFieldByName("PS payments to partners (Billable)")
def SMB = getFieldByName("S&M payments to partners (Billable)")
def LPB = getFieldByName("License payments to partners (Billable)")
def TPP = getFieldByName("3rd party products")
String NCVal = NC.getValue()
String OPNBVal = OPNB.getValue()
String HPNBVal = HPNB.getValue()
String HWNBVal = HWNB.getValue()
String PSNBVal = PSNB.getValue()
String SMNBVal = SMNB.getValue()
String LPNBVal = LPNB.getValue()
String OPBVal = OPB.getValue()
String HPBVal = HPB.getValue()
String HWBVal = HWB.getValue()
String PSBVal = PSB.getValue()
String SMBVal = SMB.getValue()
String LPBVal = LPB.getValue()
String TPPVal = TPP.getValue()
if ((NCVal != "" ||) (OPNBVal != "") || (HPNBVal != "") || (HWNBVal != "") || (PSNBVal != "") || (SMNBVal != "") || (LPNBVal != "") || (OPBVal != "") || (HPBVal != "") || (HWBVal != "") || (PSBVal != "") || (SMBVal != "") || (LPBVal != "") || (TPPVal != "")) {
    CoP.setRequired(true)
}else{
    CoP.setRequired(false)
}

Perhaps the "None" value is the reason of this issue.
Hope you help! 

Vasiliy Zverev

At first I would recommend you to refactor code like this. Current version is too hard to find bugs.

import com.atlassian.jira.component.ComponentAccessor
import com.atlassian.jira.issue.CustomFieldManager
import com.atlassian.jira.issue.Issue
import com.atlassian.jira.issue.fields.CustomField


def CoP = getFieldByName("Currency of payments to partners")
CoP.setRequired(true);

List<String> customFieldsNames = Arrays.asList(
         "NC mark-up to Billable costs (if applicable)"
        , "Other payments to partners (Non-Billable)"
        , "Hosting payments to partners (Non-Billable)"
        , "HW payments to partners (Non-Billable)"
        , "PS payments to partners (Non-Billable)"
        , "S&M payments to partners (Non-Billable)"
        , "License payments to partners (Non-Billable)"
        , "Other payments to partners (Billable)"
        , "Hosting payments to partners (Billable)"
        , "HW payments to partners (Billable)"
        , "PS payments to partners (Billable)"
        , "S&M payments to partners (Billable)"
        , "License payments to partners (Billable)"
        , "3rd party products"
)

CustomField customField;
CustomFieldManager customFieldManager = ComponentAccessor.getCustomFieldManager();

for(String fieldName: customFieldsNames){
    customField = customFieldManager.getCustomFieldObjectByName(fieldName)
    if( issue?.getCustomFieldValue(customField).equals("") ){
            CoP.setRequired(false);
        break;
    }
}