nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

User macro fails after update from 7.4 to 7.13

NKS

We used an own written macro with some velocity, some html, css and javascript. All worked well in version 7.4.7, but after the upgrade to 7.13.1 the macro does not work anymore. After a lot of debugging - I am not a developer - I am absolutely not able to find the reason. One problem is the javascript part: If I log the console output, it does what it should (set the display property of a div to block or hidden), but this change is not visible in the browser window - only the first occurency applies the change.

The other part is velocity itself. I created a simple macro to demonstrate the problem:

--------------------------------------------------------------------------------------

## Params

## ------------------------------------------

<h3>set otherpage</h3>

#set( $linkotherpage = "<ac:link><ri:page ri:content-title='$paramotherpage' /><ac:plain-text-link-body><![CDATA[Here goes the dummy text]]></ac:plain-text-link-body></ac:link>" )

<h3>set includeline</h3>

#set ($includeline = "<ri:page ri:content-title='$parampageinclude' />")

<h3>output other page from var</h3>

$linkotherpage

<h3>output direct to other page</h3>

<ac:link><ri:page ri:content-title='Testpage Link' /><ac:plain-text-link-body><![CDATA[Here goes the dummy text]]></ac:plain-text-link-body></ac:link>

<h3>include page direct</h3>

<ac:structured-macro ac:name="include" ac:schema-version="1"><ac:parameter ac:name=""><ac:link><ri:page ri:content-title="Testpage Include" /></ac:link></ac:parameter></ac:structured-macro>

<h3>include page from var</h3>
<ac:structured-macro ac:name="include" ac:schema-version="1"><ac:parameter ac:name=""><ac:link>$includeline</ac:link></ac:parameter></ac:structured-macro>

---------------------------------------------------------------------------------------

If the links are set directly, they work. If they are set from a variable, they don't work and I have absolutely no idea why. The macro above demonstrates the behavior.

Any help or idea would be really appreciated.

Thanks and regards

NKS

Accepted answers

All comments

Bill Bailey

My suggestion is to refresh your page, then check the logs to see what errors are logged at that time. Often, it will flag the issues to give you a chance at debug.

NKS

Thank you for the suggestion, but there are no errors. There is nothing logged at all if I refresh the page.

I set the log level of velocity to DEBUG and made some tests. There are several lines, but they remain the same, no matter if my macro is on the page or not. So I assume, that there is no log output from my macro.

It seems that as soon as there are chars like <, >, :, aso, in the variable, the rendering of it doesen't work anymore. This happens even in safe mode.

Bill Bailey

I notice that your variables are offset with single qoutes, but then later, you where you are testing, you are surrounding the page name with double quotes.

NKS

Yes, you are right. But unfortunately, it makes no difference. When I pass the whole line into a variable, I have no choice beside using single quotes for the page name, as I am not able to escape double quotes (or I don't know how, because none of the ways I found online are working).

If I change the double quotes to single quotes - in the "direct testing" part - the result remains the same. So I assume for velocity it makes no difference if there are used single or double quotes.

I made some further thests: I can pass the $paramotherpage or $parampageinclude to other variables. As long as I don't use any special chars, it works. At least the velocity part.

Welcome!

It looks like you're new here. Sign in or register to get started.

Quick Links

Find more posts tagged with

confluence

server

confluence-server