nav[aria-label="Primary Navigation"] { padding: 0; & ul { list-style: none; width: 100%; display: flex; flex-direction: row; justify-content: start; align-items: start; gap: 30px; padding: 0; & li { margin: 0; } & ul li { list-style: none; } } }

Can Crucible automatically add reviewers based on affected file paths?

Christopher Mar10

We desperately need a tool to help us get relevant people onto the right code reviews.

Every reviewer has familiarity with some subset of the repository, but the people submitting reviews don't know who they are. This ought to be really simple - when a diff gets added to a review, we just need to check the file paths against some pattern which is associated with the people who should be watching that content.

I don't personally know much about Crucible, so I can't tell whether this is possible. Is there a plugin API? Some hook that can run when a review changes? Some REST API that I can query to hack a cron-based solution?

Accepted answers

Christopher Mar10

Looks like the answer is no.

All comments

Aaron Booth

I know this doesn't help but in v2.8 of Crucible it used to have a "suggested reviewers" section. This was removed by Atlassian when they went to v2.9 because they said nobody used it and it was causing performance issues. It was quite frustrating as our organisation did use it.

Source: https://confluence.atlassian.com/display/CRUCIBLE/Crucible+2.9+release+notes

"With Crucible 2.9 we have removed the Suggested Reviews step during review creation. Not only does this accelerate the process, but it also ensures that performance of the whole Crucible instance is not impacted by a single process. The chart below shows the performance improvement we have seen from this modification."

I am not aware if there is a plugin that adds this back in.

Sergey Svishchev

I'd upvote your question, but that feature got removed from a.a.c too

Christopher Mar10

Looks like the answer is no.

lpater

Hi Christopher.

Actually the 'suggest reviewers' feature should provide the functionality that you're after. It looks at committers that modified the files you're trying to review the most, and suggests adding them to the review.

If you need more control/automatically add certain people you could look at the plugin or REST apis.

For the plugin api your plugin could hook ReviewCreated/ReviewUpdated events and add certain reviewers to the review. Please see https://developer.atlassian.com/display/FECRUDEV/Event+Listener+Module+Type for more information on event listener modules, and https://developer.atlassian.com/display/FECRUDEV/FishEye+and+Crucible+Java+API+Reference for Crucible's Java API reference.

For REST api you could inspect the files being reviewed using /rest-service/reviews-v1/{id}/reviewitems and add reviewers using POST /rest-service/reviews-v1/{id}/reviewers. See https://docs.atlassian.com/fisheye-crucible/latest/wadl/crucible.html for more information on Crucible's REST API.

The feature Aaron mentioned was 'suggested reviews' which allowed you to add the review to an existing one, and is unrelated to assigning reviewers.