Is it possible to use gitflow and pre-merge review with Crucible?

Jeff Ward

If we have individual users working on branches for specific features and bug fixes (in gitflow style), is it possible to do run itteritive reviews for these with Crucible?

For example, could the following workflow work in Crucible:

• Programmer works on a branch, commits and pushes this to the Crucible indexed upstream.
• Programmer creates a review
  • Code is commented on
  • Programmer fixes issues, recommits, repushes branch to Crucible indexed upstream
  • Programmer tells the review this is an iteration of the review
  • Repeat as necessary
• Review is approved and closed, and pulled into a master branch.

The only step I'm not sure about is the whether a commit can be added to a review as an iterration of that review.

Piotr Swiecicki

Yes, you can add more content to existing review, see https://confluence.atlassian.com/display/CRUCIBLE/Adding+content+to+the+review
It explains adding content in both post-commit and pre-commit reviews.

Crucible tracks reviewers' progress, each time new content is added to review they are notfied new content was added and their progress is updated accordingly.

Hope that helps,
Piotr