Using SourceTree to create Pull request from feature branch to develop branch. Pull request is waiting to be reviewed and approved (merge checks are set to not allow merges until at least one approval.)
Developer clicks on Git Flow button and click on finish Feature. Sourcetree happily does it merging all changes from feture branch to develop branch (locally)
Developer pushes all changes to Bitbucket cloud. Bitbucket happily merges everything including pull request that was NOT approved.
Is this by design? I would think that Sourcetree or Bitbucket should rehect that push request as pull request is NOT approved...
Am I missing something here?
Sourcetree is a local only Git client in many respects which is why a developer could make and push changes outside of cloud specific checks. It's up to the server (Bitbucket Cloud) to reject the push for whatever reason.
That said, it's an excellent request for us to do that check (which we can) and one we'll keep in mind for the future… to make sure it's not lost please vote, comment, or create a new ticket in either https://jira.atlassian.com/browse/SRCTREE/ (macOS) or https://jira.atlassian.com/browse/SRCTREEWIN/ (Windows)
Senior Mac Developer, Sourcetree
Supported Platforms macOS Windows We recently introduced support for additional hosting services such as GitHub Enterprise, GitLab (Cloud, Community Edition, Enterprise Edition), and...
Connect with like-minded Atlassian users at free events near you!Find an event
Connect with like-minded Atlassian users at free events near you!
Unfortunately there are no Community Events near you at the moment.Host an event
You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events