Search code for keywords to trigger Crucible review

[Jeff]

Let's say we have a small team who oversees usage of iOS UIWebView controllers. Is there some way Crucible can automatically trigger a review whenever a Perforce changelist has been committed that matches any of the following criteria:

• A new source code file has been checked in that contains a line with the word "WebView" on it
• An existing source code file has had a change to a line that contains the keyword "WebView"

Or, is there some way the small team can periodically inspect all recent Perforce commits in a given repository for such changes?

In that fashion, it makes it very easy for the small team responsible for UIWebView usage to keep on top of the code and ensure things are being used according to established best practices without having to look at every single checkin.

[Sergey Svishchev · Accepted solution]

You can use Advanced Search feature in Fisheye for this -- search for "WebView" in "Added Text" within the repository and then save the permanent link to that query (the "Link to this search" link).

[Jeff]

Thanks, this should work out well!

[John Werner]

Have you tried the Smart Commit feature? By adding special keywords to your check-in comments, you can trigger Crucible actions.

For instance, the following comment will create a new review in project "REVIEWProject" that contains all files checked in with this commit

- Updated to fix a bug, +review REVIEWProject

[Jeff]

Thanks for the input. I've found that with Smart Commit, some people have a hard time remembering to whom (or to which project) to assign reviews. So there are always some checkins floating around that should have been reviewed by 'UIWebView Owners' team (per my original example), but which are not. This is why I was looking for a proactive search feature, so 'UIWebView Owners' can do a search to catch these orphaned checkins. Combining these two approaches should give very good results.