RE: Easier access to Editor

[Philip Ross]

Hi Mohammed,

Thank you for your response and quick fix. When I go to the branch, indeed, my changes are there. But somehow, they are not reflected in the pull request, even though if I were to manually push a commit, it would automatically reflect in the existing pull requests. So this is not playing well with Stash's normal behavior.

> Hey Philip,
>
> We tracked this down to a bug where if you switched branches through the
> source view, direct committing would not work. Its fixed in release 1.4.1
> <https://marketplace.atlassian.com/plugins/com.mohamicorp.stash.plugin.editor-for-stash/versions>.
> Check it out and let us know if it works for you.
>
> In regards to editing a file in the pull request view, this is a highly
> requested feature and is on our road-map. You can keep track of it here
> <https://github.com/mdavoodi/editor-for-stash-issues/issues/1>.
>
> Thanks,
>
> Mohammed
>         [image: Upvote-icon]
> <https://answers.atlassian.com/cq/upvote.action?answerId=19141986&src=email>
> Upvote
> <https://answers.atlassian.com/cq/upvote.action?answerId=19141986&src=email>
>        In reply to      *Philip Ross*
>
> Hi. I was really hoping I'd be able to use the Editor in order to do
> really quick changes to code in existing pull requests. There appears to be
> no way to access the Editor from that view. So then I thought, fine, I have I have to go to view full source, but I can still edit there. Well, when I edit there and commit, it doesn't appear to actually commit to the branch I was on, but makes another branch off of it. That workflow obviates what I had hoped to use the tool for. Is there something that I either don't see, or any plans in the future for this? Thanks.

[Mohammed Davoodi · Accepted solution]

Hey Philip,

We've added an edit button for pull requests, and we've fixed the bug you were seeing. Check out Editor for Stash version 1.50.

Thanks,

Mohammed

[Mohammed Davoodi]

Hey Philip,

We've looked into this and see that you're right, it doesn't update the pull request. We've traced down the issue to some event processing in Stash and we'll be resolving it in version 1.5 of the editor. I'll post here again when it gets released.

With regards to the edit button on pull requests, we'll be adding that as well so stay tuned.

Mohammed

[Philip Ross]

This appears to work beautifully. Thanks, and well done!

[Philip Ross]

Mohammed,

It looks like I may have celebrated too soon. It works perfectly fine for my stash user (who happens to be a sys admin in stash, I don't know if that's related) but the rest of my team gets errors when they hit the edit icon.

Sometimes, they get a "401, Access is denied" error, and sometimes they get a "500, Oops, an error occurred Please see your system administrator."

If it makes a difference, in my setup, there are branches where write access is limited to a certain user group. But the users trying to edit the pull requests should have write permissions to both the source and destination branches.

Philip

[Mohammed Davoodi]

Hey Philip what Stash version are you on? You have to use Editor for Stash 1.5 for Stash 3.10.X

[Philip Ross]

I'm on Stash 3.10.2

[Mohammed Davoodi]

Stash 3.10.2 has a branch permissions bug. Use Editor for Stash 1.5 or upgrade to Stash 3.11. Editor for Stash 1.5 has the same functionality as 1.5.0.1. Let me know if that works for you.

[Philip Ross]

You were right. Upgrading to Stash 3.11.1 fixed my issue. Thanks!