Auto-merge: approvalQuota + groupQuota

Dakota Hawkins May 19, 2016

We have a group (with 3 people) auto-added to pull requests, and want the auto-merge to require one member of the group plus one other person (somebody not in the group).

We tried to accomplish this with "approvalQuota >= 100% & groupQuota >= 1", however the approvalQuota also applied to all members of the group.

Is there a way to make this work?

Thanks!

1 answer

0 votes
Ulrich Kuhnhardt _IzymesDev_
Rising Star
Rising Star
Rising Stars are recognized for providing high-quality answers to other users. Rising Stars receive a certificate of achievement and are on the path to becoming Community Leaders.
May 25, 2016

Try adding that other person as a mandatory reviewer. Then also set the approvalQuota to a small value (say 10%). Workzone will check if at least one person from the group has approved AND if the mandatory reviewer has approved. 

Dakota Hawkins May 26, 2016

In our case, it's up to the user submitting the pull request to add the other person. It could be whoever they want, probably usually whoever did their code review or just somebody on their team or something like that.

The way it works makes sense in retrospect, but we mistakenly thought that approvalQuota included individuals who are not a part of a group. That might be worth clarifying in the documentation.

We were able to get it to work more or less OK for us now by using "groupQuota >= 1" along with the built-in requirement that pull requests be approved by two people. So now they have to have at least two approvals, and at least one of those has to be from our group.

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events