Pushing git notes causes long delays in Control Freak hook with "Block all large files" feature

[Kanstantsin Charnukha]

Prerequisites:

- Hundreds of commits in repository

- Each commit has git note attached

- Each git note has size from hundreds of bytes to a couple of KB and never exceeds size limit.

- "Block all large files" feature in Control Freak is on. Size limit is set to 1 MB.

At some point we noticed that pushing new git notes with

git notes --ref my_notes_ref add -f -F <note_json_path> <commit_hash>
git push origin my_notes_ref

started taking too much time (30 seconds to two minutes).

After investigating the cause, it turned out that Control Freak hook is taking all the time.

Disabling "Block all large files" feature decreased push time to 1-2 seconds.

Changing Size limit did not affect push time.

It seems like hook may try to traverse all commits available in repo to analyze file size during git notes push.

Is there a chance that the issue is fixed in future releases?