jira workflow condition for crucible "no open reviews" isn't working as expected

Jeannette Lamb June 29, 2014

This condition only works properly when the crucible review is in the "Under Review" status. If the review is "Draft" or "Summarise", the condition isn't preventing the JIRA issue from being closed. It only considers "Under Review" to mean "Open".

I was expecting any state other than "Closed" would mean "Open".

Has anyone else come across this and if so how did you resolve it?

Thank you,

Jeannette

2 answers

1 accepted

0 votes
Answer accepted
Matheus Fernandes
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
July 1, 2014

I've just been testing and reviewing this locally, and this is actually the expected behavior. Reviews that are still in Draft are not considered by JIRA as it is not a valid review status (Draft Reviews are not yet completed or released to the reviewers); and Summarized reviews are past the reviewing phase as per Roles and Status Classifications.

So considering that these are the only four status Crucible has, only Under Review means open - draft is in a "pre-opened review" state, while the other two mean that the reviewing phase is finished.

Jeannette Lamb July 20, 2014

It doesn't solve my problem but I'll have to accept this as the answer I suppose.

For anyone else experiencing this issue, see https://support.atlassian.com/browse/JSP-197216for further dialog.

0 votes
Jacob Weber January 16, 2018

This would be okay if you could also use the "no unreviewed changesets" condition to catch changes that don't have a review.

But it looks like that condition passes when reviews are in Draft or Abandoned mode (see https://jira.atlassian.com/browse/CRUC-6817).

So even if you have both conditions, someone can just open a draft review and bypass them both. They won't be considered "unreviewed" changes, and they won't be considered "open" reviews.

(The link above to https://support.atlassian.com/browse/JSP-197216 no longer works, so I couldn't tell if this issue was addressed there.)

Suggest an answer

Log in or Sign up to answer