getCommentsForUser vs getComment which one to use and when ?

As per getComment method comment of   CommentManager we need to use getCommentsForUser for permission checks, but I could not fine any difference. Can any one suggest a test that shows the problem with getComment would be grateful. Thanks in advance.

1 answer

1 accepted

This widget could not be displayed.
Chris Fuller Atlassian Team Jun 06, 2016

This is in reference to the ability to restrict comments:

RestrictedComment.png

 

If you're making a request as a user that has permission to see all of the existing comments, then there would not be any difference.  If you have a project administrator restrict a comment to the Administrators role, then mere Developers should not be able to see it when you are using the method that enforces permission checks.

Chris Fuller Atlassian Team Jun 06, 2016

One of our own tests for it goes something like this (edited for brevity):

when(mockProjectRoleManager.isUserInProjectRole(author, adminProjectRole, issueObject.getProjectObject())).thenReturn(false);
final ApplicationUser admin = new MockApplicationUser("Admin");
Comment comment = commentManager.create(issueObject, admin, "comment for admins", null, adminProjectRole.getId(), false);


final List<Comment> comments = commentManager.getCommentsForUser(issueObject, author);
assertEquals("User was NOT in the role so he should not see the comment", 0, comments.size());

Thanks for the great response Chris Fuller  with sample testcases !!. 

Suggest an answer

Log in or Sign up to answer
Community showcase
Posted Tuesday in Jira

What modern development practices are at the heart of how your team delivers software?

Hey Community mates! Claire here from the Software Product Marketing team. We all know software development changes rapidly, and it's often tough to keep up. But from our research, we've found the h...

203 views 1 3
Join discussion

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you