Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Next challenges

Recent achievements

  • Global
  • Personal

Recognition

  • Give kudos
  • Received
  • Given

Leaderboard

  • Global

Trophy case

Kudos (beta program)

Kudos logo

You've been invited into the Kudos (beta program) private group. Chat with others in the program, or give feedback to Atlassian.

View group

It's not the same without you

Join the community to find out what other Atlassian users are discussing, debating and creating.

Atlassian Community Hero Image Collage

Why do Clover for IntelliJ IDEA class metrics include filtered methods.

My project contains a class with a private constructor, five getter methods, and an override of toString(). I have configured a Method filter to exclude toString methods. In Metrics in the Cloverage tool window, the value of the Methods metric is 7. In the editor window, the toString method is shown in a grey colour.

Why isn't the value of this metric 6?

Another thing I've noticed is that, after I run all the unit tests in the module that contains my class using a JUnit run configuration, the value of the Methods metric changes to 6. If I then click on the Refresh Coverage button in the Cloverage tool window, the value changes to 7.

Environment: Windows 7 Professional SP1, IntelliJ IDEA 2016.2, Clover plugin version: idea-4.1.1.v20151207000000

2 answers

1 accepted

0 votes
Answer accepted

Thank you very much for providing code sample. I reproduced the problem. After configuring the method context filter in IDEA, I can see that toString method is excluded in the source view, but not excluded in metrics. It also does not use method filters when exporting it to HTML report. I reported an issue here:

https://jira.atlassian.com/browse/CLOV-1964

OK, thanks Marek.

0 votes
  1. Which IDEA version and Clover version do you have?
  2. Class metrics should omit methods which are filtered-out. Can you confirm that configured an exclusion filter based on the method signature and not the statement? In other words that you do exclude the entire method and not just its body?
  3. Class metrics take into account also methods declared inside other methods (for instance a method may returns an anonymous inline class containing other methods - they are counted too). Can you confirm that your getters have no anonymous inline classes and no lambda functions?

 

  1. I've added environment information to my original topic. 
  2. In Clover (project settings) > Contexts > Custom Contexts, I've added a custom context called "toString" of type "Method" and regexp "(.* )?public String toString\(\).*" In the class editor, the whole toString method is highlighted in grey.
  3. I can confirm that the getters have no anonymous inline classes and no lambda functions.

The project is a Maven project and we also use the Maven Clover plugin to check test coverage and generate a test coverage report. In the Maven report, the value of the Methods metric is 6 and not 7, which is why I started looking into this.

The class is ...

 

public enum EditedOperandEnum implements ValuedEnum<String>
{
// Elements
  LT( "LT", "<" ),
LE( "LE", "<=" ),
EQ( "EQ", "=" ),
GE( "GE", ">=" ),
GT( "GT", ">" );

/** Default Valued Enumeration */
  private static final EditedOperandEnum mDefault = GE;

/** Valued Enumeration Value */
  private final String mValue;

/** Valued Enumeration Label */
  private final String mLabel;

private EditedOperandEnum( final String value, final String label )
{
mValue = value;
mLabel = label;
}

public String getLabel()
{
return mLabel;
}

public String getName()
{
return name();
}

public int getOrdinal()
{
return ordinal();
}

public String getValue()
{
return mValue;
}

public boolean isDefault()
{
return equals(mDefault);
}

public String toString()
{
return ValuedEnumUtil.toString(this);
}
}

Suggest an answer

Log in or Sign up to answer
TAGS
Community showcase
Published in Jira

Jira Cloud Performance Improvements

Hello everyone, I am a product manager in the Jira Cloud team focused on making sure our customers have a delightful experience using our products. Towards that goal, one of the areas which is extr...

173 views 2 9
Read article

Community Events

Connect with like-minded Atlassian users at free events near you!

Find an event

Connect with like-minded Atlassian users at free events near you!

Unfortunately there are no Community Events near you at the moment.

Host an event

You're one step closer to meeting fellow Atlassian users at your local event. Learn more about Community Events

Events near you