pull request code review

Denys Trofymenko December 5, 2017

we have a developper that makes the code review of the pull request. and some of the comments he made are only shown in the "overview" tab of the pull request, but not in the "diff" tab.

 

also some comments were lost and we are not sure why.

2 answers

0 votes
Denys Trofymenko December 5, 2017

we are investigating a bit more on this, and found that the comments were actually not lost, they are just not visible on teh side-by-side window, and they are visible on the "unified" window.

 

attached are 2 screenshots of the same pull request, with difference of only few seconds (the time that took me to switch to side by side window) and you can see that on the same lines where unified shows the comments, side by side is not showing anything..bitbucket_error_side_by_side.jpg.pngbitbucket_error_unified.jpg

Denys Trofymenko December 5, 2017

but at other places of the same file, side by side does show some comments, but not all the comments that we can see iin the "unified view".

0 votes
somethingblue
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
December 5, 2017

HI Denys,

I attempted to reproduce this issue in BitBucket server and was able to see the comments in the diff and the overview tab.  Can you provide the exact steps the developer goes through to perform the code review?

Cheers,

Branden

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events