Stash pull request for code reviews

Hello,

Out team would like to use Stash our some other Atlassian tool to help with performing code reviews.   We currently have an antiquated method where we use a MS Word template to list defects.

It seems like Stash's pull request might be able to help with code reviews but I am unsure if it can be used for code reviews in which we need to review an entire file (not just diffs).  

We currently use the Git-flow workflow (using SourceTree) and it would be nice to perform the code review before merging to the develop branch.

 

Thanks,

3 answers

Hi Jim,

I seems Stash can deliver what you are expecting, as using the Pull Requests you can see not just the diffs, but actually the entire content of the file. Stash will just highlight the differences.

This review will be done prior to merging then, after your code is reviewed, you can merge your code using the Merge feature included in the Pull Request. Please check Using pull requests in Stash for further details.

Regards,

Gustavo Refosco

Hi Gustavo,

 

It didn't appear that I could add comments to file when I am in 'full source' view.  Only when showing diffs.  Is there a way to allow comments for 'full source' view?

Hi Jim,

In fact you can't add comments to the full source view, as this view goes outside the pull request. With my previous response I meant you should be able to see the full source within the pull request. You can achieve this by:

  • Using the Side-by-side diff (click in the ... ellipsis button > Side-by-side diff)
  • With the Unified Diff view, scroll to the bottom of your code and right below the last line you can click to expand the code.

Regards,

Gustavo Refosco

Suggest an answer

Log in or Sign up to answer
Atlassian Community Anniversary

Happy Anniversary, Atlassian Community!

This community is celebrating its one-year anniversary and Atlassian co-founder Mike Cannon-Brookes has all the feels.

Read more
Community showcase
Piotr Plewa
Published Dec 27, 2017 in Bitbucket

Recipe: Deploying AWS Lambda functions with Bitbucket Pipelines

Bitbucket Pipelines helps me manage and automate a number of serverless deployments to AWS Lambda and this is how I do it. I'm building Node.js Lambda functions using node-lambda&nbsp...

1,755 views 1 5
Read article

Atlassian User Groups

Connect with like-minded Atlassian users at free events near you!

Find a group

Connect with like-minded Atlassian users at free events near you!

Find my local user group

Unfortunately there are no AUG chapters near you at the moment.

Start an AUG

You're one step closer to meeting fellow Atlassian users at your local meet up. Learn more about AUGs

Groups near you