Create
cancel
Showing results for 
Search instead for 
Did you mean: 
Sign up Log in

Pull request approval process issues

Jaye Bass April 5, 2017

For a given repository, we have two ways of setting minimum number of reviewer approvals to get a pull request into a mergable state. In the Default Reviewers settings page one can enter the number of Approvals Required. In the documentation for this you state: In the Approvals required field, select how many reviewers must approve pull requests that match this criteria before merging. 

This does not appear to do anything. To get an actual barrier between pull requests and merges, one must set Requires Approvers field in the Pull Request setting page.

Seems to me these two fields should be linked. If I set the Approvals Required field in the Default Reviewers settings page, that setting should be forwarded to Requires Approvers field in the Pull Request setting page.

1 answer

0 votes
Ana Retamal
Atlassian Team
Atlassian Team members are employees working across the company in a wide variety of roles.
April 11, 2017

Hi Jaye, enabling just one of them should be enough. Can you let us know which version of Bitbucket Server are you using? Also, can you send us the following screenshots?:

  • In the Default Reviewers settings enter a number in Approvals Required. Go to the Pull Request you need to merge and take a screnshot.
  • Then, go to the Pull Request settings page and set the Requires Approvers field. Go to the Pull Request you need to merge and take another screnshot.

Cheers!

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events