Pull-Request fetures

youxing98 February 25, 2013

hello, we are trying to utilizing Pull-Request features for code review process, what we want to accomplish is to:

1. developers made the code change and create Pull-request

2. reviewers will approve/un-approve the Pull-request

3. only after pull-request is approved, it will be allowed to be merged.

but as far as I understand, pull-request is loosely designed and have the following problem:

1. it allows observer to approve the code as participant

2. it allow contributor to merge the pull-request even before the code is approved

Can you help with the above issue? Thanks a lot!

2 answers

1 accepted

0 votes
Answer accepted
youxing98 February 26, 2013

Hey Simon,

Thank you for the suggestions.

1. it allows observer to approve the code as participant

You can use branch permissions to control who can push/delete a branch.

But, I think you might be after these new features:
https://jira.atlassian.com/browse/STASH-3140
https://jira.atlassian.com/browse/STASH-2999

Feel free to leave feedback on the JIRA tickets above and vote for the issues, if you'd like them implemented.

Thanks,
Ajay.

0 votes
youxing98 February 26, 2013

Hey Simon,

Thank you for the suggestions.

1. it allows observer to approve the code as participant

You can use branch permissions to control who can push/delete a branch.

But, I think you might be after these new features:
https://jira.atlassian.com/browse/STASH-3140
https://jira.atlassian.com/browse/STASH-2999

Feel free to leave feedback on the JIRA tickets above and vote for the issues, if you'd like them implemented.

Thanks,
Ajay.

Suggest an answer

Log in or Sign up to answer
TAGS
AUG Leaders

Atlassian Community Events