Changing Condition in aws-ecr-push-image to pipe.py to check ECR_PUBLIC against "true"

[Knittchen]

Hi @Igor Stoyanov

could you please change the lines

def resolve_ecr_public():
   if os.getenv("ECR_PUBLIC"):

in https://bitbucket.org/atlassian/aws-ecr-push-image/src/master/pipe/pipe.py. to

def resolve_ecr_public():
   if os.getenv("ECR_PUBLIC") == "true":

 So currently I believe it just checks if ecr_public env is existing by returning the value as a string, if so its true. This results in, ECR_PUBLIC is true even if you declare it as false in the variables:

ECR_PUBLIC: "false"

empty values are not allowed.

But if value get checked against "true" specifically, the pipe could get a dynamic value (eighter overwriting default "false" or "true" and therefore bitbucket pipeline yml configs can get much smaller. and allows conditional values, regarding  pushing to certain repos.

Kind regards,

Knut

[Igor Stoyanov]

@Knittchen hi. Thank you for your suggestion. Our team will implement changes to this logic and notify you.

Regards, Igor

[Knittchen]

Hey Igor,

thank you for the quick response.

I am looking forward the notification.

Kind regards,

Knut